[Webkit-unassigned] [Bug 117132] [EFL] onended Event is not received in AudioBufferSourceNode and OscillatorNode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117132





--- Comment #2 from Christophe Dumez <dchris at gmail.com>  2013-06-03 00:39:29 PST ---
(From update of attachment 203555)
View in context: https://bugs.webkit.org/attachment.cgi?id=203555&action=review

> Source/WebCore/ChangeLog:3
> +        [EFL] onended Event is not received in AudioBufferSourceNode and OscillatorNode.

Patch is not specific to EFL so please remove [EFL] tag.

> Source/WebCore/ChangeLog:11
> +        No new tests. Present layout tests will cover all the scenarios.

Then why doesn't this patch unskip / rebaseline any existing test?

> Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp:-172
> -    m_hasEndedListener = listener;

Could you be more explicit about what was wrong with this assignment? Was the issue that listener becomes NULL after the call to setAttributeEventListener()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.