[Webkit-unassigned] [Bug 119137] [CSS Regions] Selecting text through different regions flow does not match with highlight

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119137





--- Comment #8 from Manuel Rego Casasnovas <rego at igalia.com>  2013-07-31 13:44:21 PST ---
(In reply to comment #7)
> Created an attachment (id=207874)
 --> (https://bugs.webkit.org/attachment.cgi?id=207874&action=review) [details]
> additional test case
> 
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (From update of attachment 207639 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=207639&action=review
> > > 
> > > > Source/WebCore/ChangeLog:1
> > > > +2013-07-29  Javier Fernandez  <jfernandez at igalia.com>
> > > > LayoutTests/ChangeLog:1
> > > > +2013-07-29  Manuel Rego Casasnovas  <rego at igalia.com>
> > > 
> > > The author is different for the 2 changelogs. Is it intentional?
> > > 
> > 
> > The WebCore patch was extracted, actually, from the patch posted at bug #106817, but, since it covers only a specific case, a new and simpler test was added. I guess that's the reason, but rego should tell. 

About the author it was just basically because of Javi did the patch itself and I wrote the test. But we can change it if you think it's wrong.

> Thanks for the clarification. I ramped up on the topic now. We should go along with this approach for now. I like the change, but I miss some other cases from the solution. 
> I attached a test case which includes some bad smell. As you see the highlighted content and the actual selected content isn't going to be the same. Can you take a look at it? 
> In the meantime I'm going to raise some questions in the previous bug to Ryosuke.

The idea of this patch was just to fix the initial issue. As stopping the highlight at render side don't seem like the best option compared to doing the same at editing side.

We know that there're still more use cases pending to be fixed. Some of them (like the one you attached) are fixed with the patch for bug #106817 (and other more complex will appear under the meta bug #118668). However, we preferred to split this in order to make easier the review process.

So, this is a first simple patch to fix some concrete issues of doing this in the render side instead of editing side. Maybe we could get this initial patch landed and carry on fixing other stuff in later bugs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.