[Webkit-unassigned] [Bug 119277] Reduce JSC API static value setter/getter overhead

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119277





--- Comment #4 from Yi Shen <max.hong.shen at gmail.com>  2013-07-30 15:16:31 PST ---
(In reply to comment #3)
> Attachment 207770 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObjectFunctions.h', u'Source/JavaScriptCore/API/JSObjectRef.h', u'Source/JavaScriptCore/ChangeLog']" exit_code: 1
> Source/JavaScriptCore/API/JSObjectRef.h:55:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
> Source/JavaScriptCore/API/JSObjectRef.h:56:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
> Total errors found: 2 in 3 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

The existing & new added JSPropertyAttribute are not using InterCaps with and initial capital letter, which makes the style checker unhappy. But I think we should keep that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.