[Webkit-unassigned] [Bug 119082] Implement canvas blending tests to validate operators between different types of layers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 06:08:26 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119082





--- Comment #6 from Mihai Tica <mitica at adobe.com>  2013-07-30 06:08:13 PST ---
Thanks for the review!

(In reply to comment #3)
> (From update of attachment 207459 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207459&action=review
> 
> Suggestion: the expected test results can't be reference HTMLs with <img> tags inside for every square?
Well, that would be just hiding pixel tests. Since different platforms might generate different png results, I' d rather not try this approach.
> A nit: please use spaces instead of tabs for indentation.
Done.
> 
> > LayoutTests/fast/canvas/canvas-blending-helpers.js:45
> > +    // Soft light seems to be using a slightly different formula.
> 
> A different formula in the WebKit implementation? If yes, can you add a FIXME and a bug number for easier tracking?
Done.
> 
> > LayoutTests/fast/canvas/canvas-blending-helpers.js:152
> > +// The actual expected return value is commented.
> 
> Bugged in the implementation? If yes, can you add a FIXME and a bug number for easier tracking?
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list