[Webkit-unassigned] [Bug 118185] Gmail reply email - Bold and Italic style get stuck

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 30 04:52:35 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=118185





--- Comment #35 from vanivhegde at gmail.com  2013-07-30 04:52:21 PST ---
Hi rniwa,
I have made changes as per your review comments. Please have a look.

Few explanations:
1) var elementsForDumpingMarkupList = [document.createElement('ol')];
 Have initialized the list with <ol> to avoid the failure of existing test cases

2) function startNewMarkupGroup(label) {
if (!elementsForDumpingMarkupList[elementsForDumpingMarkupList.length - 1].hasChildNodes())
    elementsForDumpingMarkupList.pop();

This is to avoid logging empty <ol>s. This happens if we invoke startNewMarkupGroup(if we want to log some data before actual test results) before invoking execCommand* functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list