[Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99352





--- Comment #42 from Brian Holt <brian.holt at samsung.com>  2013-07-30 03:00:42 PST ---
(From update of attachment 207532)
View in context: https://bugs.webkit.org/attachment.cgi?id=207532&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:202
>> +    ProtectionSpaceAuthenticationScheme oldScheme = request->priv->authenticationChallenge->protectionSpace()->authenticationScheme();
> 
> Why is this old scheme?

I was struggling to come up with a useful variable name.  In the later patch I changed to psScheme, but suggestions are welcome.

>> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:214
>> +        scheme = WEBKIT_AUTHENTICATION_SCHEME_UNKNOWN;
> 
> Ditto. Why this special case instead of using ProtectionSpaceAuthenticationSchemeUnknown. I think we could just use the same values than WebCore and add compile time checks.

Agreed

> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:253
> +    request->priv->authenticationChallenge->listener()->useCredential(0);

I know we've discussed this before but I propose to change this to  so that the request->priv->authenticationChallenge->listener()->cancel(); so that the cancel() function is actually plumbed.  For those what want to authenticate with no credentials, just pass 0 into _authenticate().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.