[Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99352





--- Comment #41 from Brian Holt <brian.holt at samsung.com>  2013-07-30 01:37:38 PST ---
(In reply to comment #40)
> (In reply to comment #34)
> > (In reply to comment #31)
> > > so it seems that the auth scheme is mismatching somewhere. 
> > 
> > Hmmm, I'll take a look at that
> 
> Some more information:
> 
> Breakpoint 2, webkit_authentication_request_get_scheme (request=0xbde520) at ../Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:198
> 198     {
> (gdb) n
> 199         g_return_val_if_fail(WEBKIT_IS_AUTHENTICATION_REQUEST(request), WEBKIT_AUTHENTICATION_SCHEME_UNKNOWN);
> (gdb) fin
> Run till exit from #0  webkit_authentication_request_get_scheme (request=0xbde520) at ../Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:199
> 0x0000000000410349 in authenticate_cb (view=0x6a63c0, request=0xbde520, data=0x0) at src/gui.c:779
> 
> so it looks like WEBKIT_IS_AUTHENTICATION_REQUEST(request) is failing…
> 

I checked this in my unit test and it seems the problem was that the case was falling through to default (no break).  In the latest patch it should work fine, but perhaps you want to hold off testing again until I submit a final patch.

> > > I also see m_previousFailureCount in there. Is it worth plumbing that through (at least as a "has this auth been tried before?" property)?
> > 
> > Sure I'll add a _get_previous_failures() function
> 
> Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.