[Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118445


Allan Sandfeld Jensen <allan.jensen at digia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207542|review?                     |review-
               Flag|                            |




--- Comment #29 from Allan Sandfeld Jensen <allan.jensen at digia.com>  2013-07-29 07:01:38 PST ---
(From update of attachment 207542)
View in context: https://bugs.webkit.org/attachment.cgi?id=207542&action=review

Looks good but the keyIdentifiers will be wrong.

> Source/WebCore/platform/qt/PlatformKeyboardEventQt.cpp:640
> +        m_keyIdentifier = keyIdentifierForQtKeyCode(m_windowsVirtualKeyCode);

This is wrong. The translation in keyIdentifierForQtKeyCode depends on the Qt keys being set correctly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.