[Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99352





--- Comment #33 from Brian Holt <brian.holt at samsung.com>  2013-07-29 02:13:05 PST ---
(In reply to comment #30)
> (In reply to comment #29)
> > Looks great! I'll try testing it out with uzbl tonight.

Much appreciated for trying it out! It's really encouraging to see that this is likely to get some use and for the early working feedback!

> 
> First, the headers are missing from the variable which has the list of headers to install (webkit2gtk_h_api?).
> 

Well spotted, I didn't know about that variable.

> So some differences I see compared to WebKit1 (which used libsoup directly) is that there's no indication of whether the authentication is for a proxy or not (looks to be accessible from WebCore::ProtectionSpaceServerType), and the paths which are affected by the request (which doesn't look like it's plumbed through WebCore at all).
> 

I can add an _is_proxy() function.

> Also, the port from the request is a gint; maybe it makes more sense as a guint (as the port method on WebKitSecurityOrigin uses)?

I agree

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.