[Webkit-unassigned] [Bug 119117] Fix the wrong refining ArrayMode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119117





--- Comment #8 from Filip Pizlo <fpizlo at apple.com>  2013-07-25 21:35:11 PST ---
(In reply to comment #7)
> (In reply to comment #5)
> > (From update of attachment 207500 [details] [details])
> > Yeah, this makes no sense whatsoever.  The base is the array.  Your fix makes it so that every array access becomes a generic access (i.e. function call).  It defeats the whole purpose of having an optimizing compiler.
> 
> But.. there is already if (!isInt32Speculation(index)), so if any index is not int32, it becomes a generic access, I think it is wrong.

Why is that wrong?  The purpose of GetByVal optimizations is just to handle the case where the index is predicted to be an int32.

> I hope that I have misunderstood about that. But I am curious abot that. Plz teach me.
> 
> And there is another review requests on https://bugs.webkit.org/show_bug.cgi?id=117281, Does anyone can review that? Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.