[Webkit-unassigned] [Bug 119103] ANGLE needs Windows build system

Thu Jul 25 14:02:09 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=119103

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207482|review?                     |review+, commit-queue-
               Flag|                            |

--- Comment #2 from Brent Fulgham <bfulgham at webkit.org>  2013-07-25 14:01:59 PST ---
(From update of attachment 207482)
View in context: https://bugs.webkit.org/attachment.cgi?id=207482&action=review

r=me

> Source/ThirdParty/ANGLE/ANGLE.vcxproj/ANGLEGenerated.vcxproj:130
> +    <NMakePreprocessorDefinitions>WIN32;NDEBUG;</NMakePreprocessorDefinitions>

Stuff like this should be coming from the property sheets.  Visual Studio seeds this automatically, so it's probably just a matter of deleting the "local" override of the settings from the property sheet.

You can land as-is and we can clean up in a separate step.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.