[Webkit-unassigned] [Bug 119084] [Win] Compile fix.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119084





--- Comment #3 from Brent Fulgham <bfulgham at webkit.org>  2013-07-25 13:15:24 PST ---
(From update of attachment 207453)
View in context: https://bugs.webkit.org/attachment.cgi?id=207453&action=review

I want olliej or ggaren to double-check this, but it seems fine to me.

Due to Visual Studio's decision to not support inline assembly in 64-bit builds, we'll also have to start adding external ASM files on Windows builds.  Maybe this code could should end up in such an external file.

> Source/WTF/wtf/Atomics.h:278
> +#if OS(WINDOWS)

Shouldn't this be inside the "#if ENABLE(COMPARE_AND_SWAP)" macro?  I wonder if this block shouldn't be a sibling of the existing "#if CPU(X86) || CPU(X86_64)".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.