[Webkit-unassigned] [Bug 119025] Rename WebColorChooserProxy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 24 16:56:06 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119025


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207417|review?                     |review+
               Flag|                            |




--- Comment #12 from Brady Eidson <beidson at apple.com>  2013-07-24 16:55:55 PST ---
(From update of attachment 207417)
View in context: https://bugs.webkit.org/attachment.cgi?id=207417&action=review

> Source/WebKit2/ChangeLog:10
> +        Rename WebColorChooserProxy to WebColorPicker since the name WebColorChoooserProxy
> +        implies a one-to-one relationship with WebColorChooser, which will not be true when
> +        the patch for bug 61276 lands.

Nitpick - It's not even true *now*

Yes, the WebProcess has 1 WebColorChooser, and the UIProcess has 1 WebColorChooserProxy...  but they aren't actually connected.

The Object/ObjectProxy naming scheme is for a pair of objects that represent the identical object/concept on both sides of the IPC connection, so tightly intertwined that they message each other directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list