[Webkit-unassigned] [Bug 118908] [ATK] Issues with edge cases when getting offsets for a text range in AtkText

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118908


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207114|review?                     |review+
               Flag|                            |




--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2013-07-24 10:57:25 PST ---
(From update of attachment 207114)
View in context: https://bugs.webkit.org/attachment.cgi?id=207114&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:521
> +    // Default values, unless the contrary is proved.

This comment seems superfluous.

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:538
> +        startOffset = comparePositions(selection.start(), firstValidPosition) < 0 ? 0 : accessibilityObjectLength(coreObject);

So if the selection is after the node then you return accessibilityObjectLength as the start and end offsets?

> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:560
> +    int rangeLength = TextIterator::rangeLength(nodeRange.get(), true);

Looks like you can avoid this temporary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.