[Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99352





--- Comment #24 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-07-24 08:05:16 PST ---
(In reply to comment #23)
> (From update of attachment 207310 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207310&action=review
> 
> >> Source/WebKit2/UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:91
> >> + * webkit_authentication_request_can_save_credential:
> > 
> > Reading this again I've noticed that the names suggest that there's a specific credential for which you are checking if persistent storage is allowed, but this is generic, maybe we could use webkit_authentication_request_can_save_credentials instead. Maybe Martin or Gustavo have any other suggestion?
> 
> I agree, credentials makes it more understandable. I wonder if this needs to be a WebKitAuthenticationRequest method, perhaps it should go in the Context?

I agree it is global and not specific to the given request, but it can't be in the context either, since it depends also on whether private browsing is enabled, so it actually depends on the web view group. I think having it in WebKitAuthRequest is very convenient to use.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.