[Webkit-unassigned] [Bug 99352] [GTK] [WebKit2] Add an 'authenticate' signal to WebKitWebView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99352





--- Comment #18 from Mario Sanchez Prada <mario at webkit.org>  2013-07-23 11:15:17 PST ---
(In reply to comment #16)
> Unfortunately the unit test where I was planning to test this functionality is 
> being skipped because its failing: https://bugs.webkit.org/show_bug.cgi?
> id=117689.

That is bad luck :). Fortunately, I don't think that test will be skipped forever so that should not hold you form writing the test in the right place.

> One option is to create a new test TestWebKitAuthentication.cpp, although it 
> seems like it belongs in TestWebKitWebView.

Yes. As the central point of this API addition is the signal you are adding to WebKitWebView, this new unit test should IMHO be added there.

You'll probably want to create a subclass of WebViewTest inside of TestWebKitWebView.cpp as well to write that new unit test, btw.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.