[Webkit-unassigned] [Bug 100379] [Win] WebView didReceiveIcon delegate call doesn't have the icon in it

Tue Jul 23 09:52:09 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=100379

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #204703|review?                     |review-
               Flag|                            |

--- Comment #12 from Brent Fulgham <bfulgham at webkit.org>  2013-07-23 09:52:01 PST ---
(From update of attachment 204703)
View in context: https://bugs.webkit.org/attachment.cgi?id=204703&action=review

Sorry -- I didn't notice that we would have to cast that sz variable from IntSize to SIZE. Please correct that and I'll r+ it (today!)

> Source/WebKit/win/WebView.cpp:2882
> +            icon->getHBITMAPOfSize(hBitmap, &(SIZE)sz);

This should be written as "&static_cast<SIZE>(sz)"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.