[Webkit-unassigned] [Bug 118445] [Qt] QtWebKit should allow sending domain specific keycode to HTML applications

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118445





--- Comment #27 from Arunprasad Rajkumar <arurajku at cisco.com>  2013-07-23 07:04:11 PST ---
(In reply to comment #26)
> (In reply to comment #25)
> > > True, but since you are generating your own QKeyEvents you are essentially a new "native" source of key-events.
> > 
> > OK. Understood :)
> > 
> > >These values are usually only there for applications that need to detect keys not fully supported or detected by Qt, similar to your case.
> > 
> > So it the platformkeyboadreventqt.cpp, instead of returning keycode directly nativeVirtualKeyCode should be passed from default: case?
> > 
> > -default:
> > -  return keycode; 
> > 
> > +default:
> > +    return event->nativeVirtualKey();
> > 
> > Am I correct?
> 
> Exactly, but you will then need a setting like passThroughŃativeVirtualKeys, or something similar. We don't want the normally (except on Windows where it would be okay)

Thanks for your suggestion. That looks good for me. Will update the patch as per your suggestion.

Is it good to call QWebSettings from platformkeyboardeventqt.cpp?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.