[Webkit-unassigned] [Bug 98348] [GTK] Reevaluate the platform-specific nature of some accessibility tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=98348


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario at webkit.org




--- Comment #1 from Mario Sanchez Prada <mario at webkit.org>  2013-07-22 06:08:06 PST ---
(In reply to comment #0)
> The following can currently be found in TestExpectations file:
> 
> # Accessibility tests that should never be run for GTK due to be
> # written in a platform-specific way. They should either be moved to
> # the right platform or re-written in a more platform-agnostic way.
> accessibility/internal-link-anchors2.html [ WontFix ]
> accessibility/radio-button-group-members.html [ WontFix ]
> accessibility/table-attributes.html [ WontFix ]
> accessibility/table-detection.html [ WontFix ]
> accessibility/table-one-cell.html [ WontFix ]
> accessibility/table-sections.html [ WontFix ]
> accessibility/table-with-aria-role.html [ WontFix ]
> accessibility/table-with-rules.html [ WontFix ]
> accessibility/plugin.html [ WontFix ]
> 
> I think we should reevaluate this classification, see if any test could be 
> rewritten in platform-independent way and otherwise either remove these tests 
> under proper platform-specific directories or just keep these expectations as 
> they are.

I agree. Actually, all those tests[*] could be fixed by implementing the corresponding attributesOf*() function in AccessibilityUIElement() for DRT/WKTR, since those functions are currently unimplemented.

More specifically, this is what needs to be implemented:

 * table-attributes.html, table-sections.html:
    - attributesOfColumnHeaders()
    - attributesOfRowHeaders()
    - attributesOfColumns()
    - attributesOfRows()
    - attributesOfHeader()
    - attributesOfVisibleCell()

 * plugin.html, table-with-aria-role.html:
    - attributesOfChildren()

 * internal-link-anchors2.html, radio-button-group-members.html:
    - attributesOfLinkedUIElements

 * table-detection.html, table-one-cell.html, table-with-rules.html:
    - allAtributes()

Additionally, implementing all those functions (specially allAttributes() and attributesOfChildren()) will help us run properly other tests as well, so it looks indeed like something interesting to fix.

I'll be filing bugs for all of them soon, and hopefully working on them too.

[*] With the exception of aria-list-and-listitem.html and accessibility/aria-option-role.html, which are no longer in the TestExpectations file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.