[Webkit-unassigned] [Bug 118926] ANGLE does not compile with code coverage analysis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118926





--- Comment #5 from Alex Christensen <achristensen at apple.com>  2013-07-19 16:33:29 PST ---
(In reply to comment #2)
> (From update of attachment 207156 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207156&action=review
> 
> > Tools/ChangeLog:10
> > +        * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
> > +        * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
> > +        (generateReport): Moved report generation to a subroutine.
> 
> You did things that you didn’t mention here.
Those were the only functional changes.  Removing useless comments wasn't worth mentioning.
> 
> > Tools/Scripts/build-webkit:-329
> > -        push @local_options, XcodeCoverageSupportOptions() if $coverageSupport && $project ne "ANGLE";
> 
> Do you know historically where this came from? it seems surprisingly specific.
> 
> > Tools/Scripts/generate-coverage-data:61
> > +system("Tools/Scripts/run-javascriptcore-tests --no-build");
> 
> why just —no-build for jsc tests? I think most of the others support that too.
The other scripts don't build by default.

I'm going to cq+ this even though mac-wk2 doesn't like it.  Nobody uses this script yet.  There is no way this broke anything.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.