[Webkit-unassigned] [Bug 118926] ANGLE does not compile with code coverage analysis

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118926


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #207156|review?                     |review+
               Flag|                            |




--- Comment #2 from Tim Horton <thorton at apple.com>  2013-07-19 16:19:28 PST ---
(From update of attachment 207156)
View in context: https://bugs.webkit.org/attachment.cgi?id=207156&action=review

> Tools/ChangeLog:10
> +        * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
> +        * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
> +        (generateReport): Moved report generation to a subroutine.

You did things that you didn’t mention here.

> Tools/Scripts/build-webkit:-329
> -        push @local_options, XcodeCoverageSupportOptions() if $coverageSupport && $project ne "ANGLE";

Do you know historically where this came from? it seems surprisingly specific.

> Tools/Scripts/generate-coverage-data:61
> +system("Tools/Scripts/run-javascriptcore-tests --no-build");

why just —no-build for jsc tests? I think most of the others support that too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.