[Webkit-unassigned] [Bug 118872] Mac port should run bison as part of ANGLE build process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118872





--- Comment #7 from Mark Rowe (bdash) <mrowe at apple.com>  2013-07-19 00:59:09 PST ---
There's a ton of duplication in that Makefile. A lot of it could be removed if you transformed it to something like so:

SEARCH_PATH = $(ANGLE)/src/compiler $(ANGLE)/src/compiler/preprocessor

vpath %.l $(SEARCH_PATH)
vpath %.y $(SEARCH_PATH)

FLEX = flex --noline --nounistd
BISON = bison --no-lines --skeleton=yacc.c

all : glslang_lex.cpp glslang_tab.h glslang_tab.cpp ExpressionParser.cpp Tokenizer.cpp

glslang_tab%h glslang_tab%cpp : glslang.y
    $(eval OUTPUT = $(basename $@))
    $(BISON) --defines=$(OUTPUT).h --output=$(OUTPUT).cpp $<

ExpressionParser.cpp : ExpressionParser.y
    $(BISON) --output=$@ $<

glslang_lex.cpp : glslang.l
    $(FLEX) --outfile=$@ $<

Tokenizer.cpp : Tokenizer.l
    $(FLEX) --outfile=$@ $<


Most of the remaining duplication only exists because of the strange naming conventions of the files in question, but I'm guessing that updating those will cause more hassle than it's worth.


The makefile also needs a license header.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.