[Webkit-unassigned] [Bug 73743] [GStreamer] webkitwebsrc: use SubResourceLoader

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73743





--- Comment #21 from Brady Eidson <beidson at apple.com>  2013-07-18 09:28:29 PST ---
(In reply to comment #20)
> The platform specific code is indeed part of the ResourceHandle, the soup implementation allows the client to provide its own read buffer, which is used by the gstreamer backend to avoid buffer copies while loading media, but it's not a gstreamer feature. 

But you just said that it's a gstreamer feature.

Each media backend tends to do things radically differently from each other, but we've successfully kept the implementation details of ours out of the general purpose, cross-platform loader code.

> The same way the mac port has platform specific support for loading the data in a CFArrayRef. 

Which is an unfortunate case and one that we hope to rectify going forward.

But also, note that this callback is *only* in SubresourceLoader, and it was not necessary to pipe it through to the entire CachedResource/CachedRawResource/CachedRawResourceClient stack of classes.

They are absolutely *not* a place for platform loading details.  It's wrong wrong wrong.

> Except for the headers, all other platform specific code is in platform-specific files. I don't see how the gstreamer loader can provide the read buffer without using the CachedRawResource client. I agree that ideally, there shouldn't be platform ifdefs in those files. Another possibility is adding getOrCreateReadBuffer unconditionally, but unimplemented in other platforms, since the method itself doesn't have any platform specific types.

Let me ask this - What advantage is gained by this bug?  The bug is titled "use SubresourceLoader", but why is that important?  Didn't things work just fine when this code was in ResourceHandle?  Why is this move important to even be contemplating?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.