[Webkit-unassigned] [Bug 102586] [GTK] media/video-src-blob.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=102586





--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2013-07-17 10:36:46 PST ---
(From update of attachment 206897)
View in context: https://bugs.webkit.org/attachment.cgi?id=206897&action=review

Looks good to me. Great work! Just a couple questions...

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:465
> +        DataBufferingPolicy bufferingPolicy = url.protocolIs("blob") ? BufferData : DoNotBufferData;
> +        CachedResourceRequest cacheRequest(request, ResourceLoaderOptions(SendCallbacks, DoNotSniffContent, bufferingPolicy, DoNotAllowStoredCredentials, DoNotAskClientForCrossOriginCredentials, DoSecurityCheck, UseDefaultOriginRestrictionsForType));
>          priv->resource = loader->requestRawResource(cacheRequest);

Why is it useful to buffer data that is already in memory on the client side?

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:605
> +    if (!url.isValid() || (!url.protocolIsInHTTPFamily() && !url.protocolIs("blob"))) {

I think this could be a helper. Something like urlIsValidAndHasSupportedProtocol or just urlHasSupportedProtocol.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.