[Webkit-unassigned] [Bug 118759] [EFL] ewk_settings_application_cache_path_set should be called once in test_ewk_setting.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118759


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206834|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Christophe Dumez <dchris at gmail.com>  2013-07-17 00:49:48 PST ---
(From update of attachment 206834)
View in context: https://bugs.webkit.org/attachment.cgi?id=206834&action=review

> Source/WebKit/efl/tests/test_ewk_setting.cpp:-127
> -    ewk_settings_application_cache_path_set("~/tmp/webkitApp");

Instead of removing the check, it would be better to keep it to make sure that:
- it does not crash (especially in debug)
- the path is not changed the second time

This may require some fixes in WebKit but I'm sure you can manage :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.