[Webkit-unassigned] [Bug 50619] [GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50619





--- Comment #23 from Denis Nomiyama (dnomi) <d.nomiyama at samsung.com>  2013-07-16 03:04:31 PST ---
(In reply to comment #22)
> Created an attachment (id=206748)
 --> (https://bugs.webkit.org/attachment.cgi?id=206748&action=review) [details]
> WIP Patch based on OPENTYPE_VERTICAL

I have modified my previous patch to use OPENTYPE_VERTICAL. This feature is not currently implemented in the GTK+ port, but since it is not very complicated, I thought it was worth giving it a try.
Although this patch is complete, it has been marked as a WIP because there are some assumptions to be discussed:

- The solution is based on OPENTYPE_VERTICAL. There is currently no maintainer for this feature in the GTK+ port, but I am happy to help on this
- This feature is disabled by default in this patch and a compilation option --enable-opentype-vertical has been introduced
- The layout tests related to vertical texts are not re-based yet because OPENTYPE_VERTICAL is disabled by default
- This patch also includes some minor coding style fixes, which are not related to the code for this fix, and if necessary I can move them to another patch to make it easier to review
- Another option for this patch is to raise a new bug for implementing OPENTYPE_VERTICAL and add it to the "Depends on" list. Then we can keep this one open until OPENTYPE_VERTICAL gets enabled by default.
- Since the code is only executed when FontPlatformData::orientation() == Vertical, the performance of horizontal text rendering should not be affected by this change

I have tested this patch against several Japanese and Chinese pages with vertical text including the ones in LayoutTests. The results are good and visually the same as shown by Chrome.

editing/selection/vertical-lr-ltr-extend-line-*
fast/repaint/japanese-rl-selection-*
fast/writing-mode/japanese-*
fast/writing-mode/vertical-*

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.