[Webkit-unassigned] [Bug 110865] [GTK] Closing inspector window crashes wk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 15 00:46:00 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=110865





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-07-15 00:47:06 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > I think it would be cleaner to delete the page in finalize instead
> > of dispose. Since WebKitWebView uses the placement new syntax, you
> > can make page a OwnPtr and it will be automatically deleted in
> > finalize.
> 
> The problem is that the corePage pointer will still be != 0 in the
> meantime, and that will produce a crash during the disposal of the
> parent class:
> 
> Program received signal SIGSEGV, Segmentation fault.
> 0x00007ffff3d2f5e8 in WebCore::AXObjectCache::rootObject (this=0x0)
>     at ../../Source/WebCore/accessibility/AXObjectCache.cpp:415
> 415         return getOrCreate(m_document->view());
> #0  0x00007ffff3d2f5e8 in WebCore::AXObjectCache::rootObject (this=0x0)
>     at ../../Source/WebCore/accessibility/AXObjectCache.cpp:415
> #1  0x00007ffff3b8f2df in webkit_web_view_get_accessible (widget=0x5da2a0)
>     at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:1416
> #2  0x00007ffff1c34ee9 in gtk_container_accessible_real_remove_gtk (container=0x449320, widget=0x5da2a0, data=0x1a8a0e0)
>     at gtkcontaineraccessible.c:137
> [...]
> #7  0x00007ffff1a2abb4 in gtk_container_remove (container=<optimized out>, widget=widget at entry=0x5da2a0)
>     at gtkcontainer.c:1546
> #8  0x00007ffff1bf6cc2 in gtk_widget_dispose (object=0x5da2a0) at gtkwidget.c:10254

hmm, unfortunate.

> A different alternative would be to run parent->dispose() first. That
> seems to work fine it doesn't look like the rest of the code in that
> method would be affected by that.

It could be easier, yes, adding a comment explaining why parent dispose is called first.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list