[Webkit-unassigned] [Bug 118583] [EFL] Add fallback for TestWebKitAPI if opengl is not available.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118583


Christophe Dumez <dchris at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206506|review?                     |review-
               Flag|                            |




--- Comment #2 from Christophe Dumez <dchris at gmail.com>  2013-07-12 07:04:49 PST ---
(From update of attachment 206506)
View in context: https://bugs.webkit.org/attachment.cgi?id=206506&action=review

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:48
> +    Ecore_Evas* ecoreEvas = 0;

initialization does not seem needed.

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:50
> +    const char* engine = "opengl_x11";

This variable is not needed. please pass "opengl_x11" directly to ecore_evas_new().

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-54
> -    ASSERT(ecoreEvas);

Why remove the assertion?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.