[Webkit-unassigned] [Bug 114871] [GTK] Reimplement atk_text_get_text_*_offset for WORD boundaries

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=114871


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #203441|0                           |1
        is obsolete|                            |
 Attachment #203441|review?                     |
               Flag|                            |
 Attachment #206528|                            |review?
               Flag|                            |




--- Comment #14 from Mario Sanchez Prada <mario at webkit.org>  2013-07-12 05:35:23 PST ---
Created an attachment (id=206528)
 --> (https://bugs.webkit.org/attachment.cgi?id=206528&action=review)
Patch proposal plus new Unit tests

After working for a while on the previous patch + the suggestions from Martin, I realized there were some issues with that patch that needed more changes, so here you have the new patch, which I believe works at least as well (or as bad) as the previous -pango based- implementation. I'd even say it works better, at least in the tests I did, but I'm prudent and won't say that :)

Additionally, I found some issues while developing it (some of them already present in the previous implementation) that I've fixed along the way with this patch, so that's why I'm also providing a new unit test for checking things related to embedded objects, and extending a bit previous ones.

I'd therefore kindly ask for a review over this one and will move on to the LINE boundary in the meantime... getting closer to the no-pango thing!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.