[Webkit-unassigned] [Bug 118549] [EFL] --minimal build fails while linking libwebcore_efl.so

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 12 04:03:33 PDT 2013


--- Comment #2 from Raphael Kubo da Costa (:rakuco) <rakuco at webkit.org>  2013-07-12 04:05:35 PST ---
(From update of attachment 206487)
View in context: https://bugs.webkit.org/attachment.cgi?id=206487&action=review

Looks OK to me, but please fix the style notes I added.

> Source/WebCore/ChangeLog:8
> +        This is fix for 11854.
> +
> +        * CMakeLists.txt: 

The bug number is already mentioned above, so there's no need to say it again. Instead, it's helpful to describe what you did in the "* CMakeLists.txt" line, like "Move file foo to the block bar because of this and that".

> Source/WebCore/CMakeLists.txt:2611
>          plugins/npapi.cpp
> +        plugins/PluginPackage.cpp

Please keep this list alphabetically (and case-sensitively) sorted.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list