[Webkit-unassigned] [Bug 117834] [ATK] Adds support for aria-haspopup property.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117834





--- Comment #18 from Krzysztof Czech <k.czech at samsung.com>  2013-07-12 02:36:23 PST ---
> > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:59
> > +    for (AtkAttributeSet* attributes = attributeSet; attributes; attributes = attributes->next) {
> 
> attributes -> attribute ?
I named it attributes because, it describes range of ATK attributes.
> 
> > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:62
> > +            attributeValue.set(g_strdup(atkAttribute->value));
> 
> The strdup would not be needed if you freed the attributeSet list *after* constructing the return String. attributeValue would then be a const char*.
> 
I agree, done.
> > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:68
> > +    return String(attributeValue.get());
> 
> String::fromUTF8(attributeValue)? iirc the string string is UTF-8 encoded, right?
> 
I guess you are right, corrected
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:64
> > +            attributeValue.set(g_strdup(atkAttribute->value));
> 
> Same comments as above.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.