[Webkit-unassigned] [Bug 117834] [ATK] Adds support for aria-haspopup property.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 11 08:08:32 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=117834
--- Comment #16 from Christophe Dumez <dchris at gmail.com> 2013-07-11 08:10:32 PST ---
(From update of attachment 206358)
View in context: https://bugs.webkit.org/attachment.cgi?id=206358&action=review
> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:59
> + for (AtkAttributeSet* attributes = attributeSet; attributes; attributes = attributes->next) {
attributes -> attribute ?
> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:62
> + attributeValue.set(g_strdup(atkAttribute->value));
The strdup would not be needed if you freed the attributeSet list *after* constructing the return String. attributeValue would then be a const char*.
> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:68
> + return String(attributeValue.get());
String::fromUTF8(attributeValue)? iirc the string string is UTF-8 encoded, right?
> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:64
> + attributeValue.set(g_strdup(atkAttribute->value));
Same comments as above.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list