[Webkit-unassigned] [Bug 118179] [ATK] Refactor code for translating offsets between WebCore a11y and ATK

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 10 17:48:44 PDT 2013


--- Comment #9 from chris fleizach <cfleizach at apple.com>  2013-07-10 17:50:45 PST ---
(From update of attachment 205897)
View in context: https://bugs.webkit.org/attachment.cgi?id=205897&action=review

>>> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:481
>>> +        return toRenderListItem(renderer)->markerTextWithSuffix().length();
>> So why does this method return 0 for listItemMarker when language is RTL?
> This is because depending on the text direction we expose the marker before or after the actual text for the list item, to better match how it's visually represented on screen.
> Thus, if it's RTL, the list item marker will be appended after the list item text in the exposed AtkObject which means we do not need to do any adjustment to the offsets when translating from Atk to WebCore or viceversa.
> However, it's true that then it's not an appropriate name for this function. Perhaps it's better to go back to the original name as the one I used in the original patch from bug 114871: offsetAdjustmentForObject(), or offsetAdjustmentForListItem(). What do you think?
> PS: In any case, we should maybe rethink this idea of appending/prepending the list item marker depending on text direction. I've checked what firefox does right now and they always prepend the list item marker when exposing AtkObjects for list items, regardless the text direction. In any case, that should be considered in a separate bug, if needed.

offsetAdjustmentForListItem() is a good name i think

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list