[Webkit-unassigned] [Bug 118447] Range.getClientRects() not working correctly for partially contained vertically styled text nodes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118447





--- Comment #3 from Sam Weinig <sam at webkit.org>  2013-07-10 11:16:30 PST ---
(In reply to comment #2)
> (From update of attachment 206397 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206397&action=review
> 
> > Source/WebCore/rendering/RenderText.cpp:338
> >                  r.setHeight(box->logicalHeight());
> >                  r.setY(box->y());
> >              } else {
> > -                r.setWidth(box->logicalWidth());
> > +                r.setWidth(box->logicalHeight());
> >                  r.setX(box->x());
> 
> Shouldn't this just be using box->width() and box->height()? Seems silly to call logical when you seem to want physical?

Agreed, I'll try that out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.