[Webkit-unassigned] [Bug 118471] [texmap][GStreamer] upload onto the texture only the buffer to be painted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118471





--- Comment #4 from Víctor M. Jáquez L. <vjaquez at igalia.com>  2013-07-10 03:27:41 PST ---
(From update of attachment 206326)
View in context: https://bugs.webkit.org/attachment.cgi?id=206326&action=review

>>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:371
>>> +    gst_buffer_map(m_buffer, &srcInfo, GST_MAP_READ);
>> 
>> Would it make sense or have any benefit to use gst_video_frame_map/unmap?
> 
> I'm wrong, the texture is not created here and passed to the caller, but fetched from the pool, so this is correct, sorry.

about using gst_frame_map/unmap, currently it doesn't bring any benefit, since the metadata is extracted from the caps using the method getVideoSizeAndFormatFromCaps(), delaying the map() operation until is truly needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.