[Webkit-unassigned] [Bug 105214] AX: Allow requesting the full plain text for an object with textUnderElement()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105214


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|AX: Need more GTK           |AX: Allow requesting the
                   |accessibility tests of the  |full plain text for an
                   |object replacement          |object with
                   |character                   |textUnderElement()




--- Comment #5 from Mario Sanchez Prada <mario at webkit.org>  2013-07-10 02:10:25 PST ---
Thanks for the review, Chris. I will provide an updated patch asap.

(In reply to comment #4)
> (From update of attachment 206160 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206160&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        AX: Need more GTK accessibility tests of the object replacement character
> 
> This title is misleading I think for what it does

Yes, that's right. I'm now changing it to something that will hopefully be more accurate

> > Source/WebCore/ChangeLog:8
> > +        Allow specifying different funtion modes for textUnderElement(),
> 
> funtion -> function

Ok.

> > Source/WebCore/ChangeLog:11
> > +        element (without omitting any child in the subtree), needed for
> 
> the portion of this sentence - ", needed for..." Should be its own sentence

Ok.

> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1509
> > +    if (mode == TextUnderElementModeFullText)
> 
> I think these modes should be called
> 
> TextUnderElementIncludeAllChildren
> TextUnderElementSkipIgnoredChildren (Default)

Agreed. It definitely sounds better and looks more clear

> > Source/WebCore/accessibility/AccessibilityRenderObject.h:147
> > +    virtual String textUnderElement(AccessibilityTextUnderElementMode) const;
> 
> this should take a default value so that we don't need to modify every instances
> TextUnderElementMode = ..

Ok. I'll add that then.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.