[Webkit-unassigned] [Bug 118471] [texmap][GStreamer] upload onto the texture only the buffer to be painted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118471





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-07-10 00:15:20 PST ---
(In reply to comment #2)
> (From update of attachment 206326 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206326&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:371
> > +    gst_buffer_map(m_buffer, &srcInfo, GST_MAP_READ);
> 
> Would it make sense or have any benefit to use gst_video_frame_map/unmap?
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:384
> > +    return texture;
> 
> This returns a PassRefPtr now, so this should return texture.release() to transfer the ownership to the caller.

I'm wrong, the texture is not created here and passed to the caller, but fetched from the pool, so this is correct, sorry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.