[Webkit-unassigned] [Bug 105214] AX: Need more GTK accessibility tests of the object replacement character

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=105214





--- Comment #4 from chris fleizach <cfleizach at apple.com>  2013-07-09 17:26:01 PST ---
(From update of attachment 206160)
View in context: https://bugs.webkit.org/attachment.cgi?id=206160&action=review

> Source/WebCore/ChangeLog:3
> +        AX: Need more GTK accessibility tests of the object replacement character

This title is misleading I think for what it does

> Source/WebCore/ChangeLog:8
> +        Allow specifying different funtion modes for textUnderElement(),

funtion -> function

> Source/WebCore/ChangeLog:11
> +        element (without omitting any child in the subtree), needed for

the portion of this sentence - ", needed for..." Should be its own sentence

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1509
> +    if (mode == TextUnderElementModeFullText)

I think these modes should be called

TextUnderElementIncludeAllChildren
TextUnderElementSkipIgnoredChildren (Default)

> Source/WebCore/accessibility/AccessibilityRenderObject.h:147
> +    virtual String textUnderElement(AccessibilityTextUnderElementMode) const;

this should take a default value so that we don't need to modify every instances
TextUnderElementMode = ..

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.