[Webkit-unassigned] [Bug 117895] [v2.1.2] GTK2 build fails for undefined GDK_IS_X11_DISPLAY

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117895





--- Comment #12 from Dominique Leuenberger <dimstar at opensuse.org>  2013-07-09 13:37:20 PST ---
(In reply to comment #11)
> Attachment 206349 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/gtk/GtkVersioning.h', u'Source/WebCore/plugins/gtk/gtk2xtbin.h']" exit_code: 1
> Source/WebCore/platform/gtk/GtkVersioning.h:44:  Missing space after ,  [whitespace/comma] [3]
> Source/WebCore/platform/gtk/GtkVersioning.h:46:  Tab found; better to use spaces  [whitespace/tab] [1]
> Source/WebCore/platform/gtk/GtkVersioning.h:46:  Extra space before ( in function call  [whitespace/parens] [4]

Ok, those three I can easily address

> Source/WebCore/plugins/gtk/gtk2xtbin.h:43:  Header file should not contain WebCore config.h. Should be: alphabetically sorted.  [build/include_order] [4]
> Total errors found: 4 in 3 files

??? That contradicts what was said earlier

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.