[Webkit-unassigned] [Bug 118060] Old Bug Validator Tool

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118060





--- Comment #11 from Csaba Osztrogonac <ossy at webkit.org>  2013-07-09 02:08:58 PST ---
(In reply to comment #10)
> Thanks for posting the patch. However, this shouldn't be a standalone python script.
Of course it can be easy to add it as a new webkit-patch command.

> There is a code to parse TestExpectations under Tools/Scripts/webkitpy/layout_tests.
> We should be using that parser instead. 

The TestExpectations parser in layout_tests/models/test_expectations.py
would be overkiller and it isn't suitable for this use case now.

It parses only "The new format for a test expectation line":
        [[bugs] [ "[" <configuration modifiers> "]" <name> [ "[" <expectations> "]" ["#" <comment>]

where bugs must be in "webkit.org/b/XXXXX" format. But there are 
URLs in the comment sections too in different formats. I don't think
if we should refactor test_expectations.py instead of the oneliner regexp.

> There is also a code to fetch Bugzilla data. See code in Tools/Scripts/webkitpy/tool.

It can be used if it doesn't have too much dependencies and 
if we can avoid the mandatory bugzilla authentication somehow.
Because it is a non-sense if we wan't to force the user to authenticate
if fetching a bugzilla URL doesn't need authentication at all.

Otherwise I still think that a urllib2.urlopen(...) oneliner is much more
simpler than solving all of these problems, because we want to integrate
everything to the existing webkitpy infrastructure regardless of expense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.