[Webkit-unassigned] [Bug 118328] Optimize addStrackTraceIfNecessary to be faster in the case when it's not necessary

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118328


Chris <chris_curtis at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #206279|0                           |1
        is obsolete|                            |
 Attachment #206285|                            |commit-queue-
               Flag|                            |




--- Comment #15 from Chris <chris_curtis at apple.com>  2013-07-08 17:36:00 PST ---
Created an attachment (id=206285)
 --> (https://bugs.webkit.org/attachment.cgi?id=206285&action=review)
Corrected and added info to the change log.

@Geoff, The remove-target-with-shadow-in-drag-expected.txt change was a trivial line number change. LayoutTests/inspector/console/console-exception-stack-traces.html is the test case that will fail without the changes to eval and decode. To answer your question, callee does not want to roll back its call frame unless it is the error frame itself(which it is in this case). I roll back the topCallFrame right before the throw. After it returns, the ~TopCallFrameSetter is invoked, which does the same action but it is needed before the vm is deallocated. Directly after the callee's vm is deallocated, add error information retrieves the information which is why the stack trace was correct the second time around and the error was never found.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.