[Webkit-unassigned] [Bug 117733] [WK2][GTK] ASSERTION in WebKit::LayerTreeHostGtk::invalidate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 8 16:16:34 PDT 2013


--- Comment #16 from Martin Robinson <mrobinson at webkit.org>  2013-07-08 16:18:35 PST ---
(From update of attachment 206265)
View in context: https://bugs.webkit.org/attachment.cgi?id=206265&action=review

The bits in WebKitWebView look good to me, but I think any fixes for LayerTreeHost should be split out into another patch. I think given your comments earlier that the approach of returning null isn't a safe one (as the assertion you added attests). I think we are just going to have to make sure that we do not return an invalid LayerTreeHost.

> Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:70
> -    return host.release();
> +    return host->m_isValid ? host.release() : 0;
>  }

It seems that we could actually dispense with this part of the patch entirely?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list