[Webkit-unassigned] [Bug 118473] [GTK] Leak: GstElement* leaking in MediaPlayerPrivateGStreamer::createAudioSink()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118473





--- Comment #5 from Brian Holt <brian.holt at samsung.com>  2013-07-08 09:52:49 PST ---
(From update of attachment 206249)
View in context: https://bugs.webkit.org/attachment.cgi?id=206249&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1578
>> +    GRefPtr<GstElement> audioSink = adoptGRef(gst_bin_new("audio-sink"));
> 
> The doc says that gst_bin_new() returns a floating reference:
> http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstBin.html#gst-bin-new
> 
> How come adopting doesn't assert here?
> template <> GRefPtr<GstElement> adoptGRef(GstElement* ptr)
> {
>     ASSERT(!ptr || !gstObjectIsFloating(GST_OBJECT(ptr)));
>     return GRefPtr<GstElement>(ptr, GRefPtrAdopt);
> }

Thanks very much for the link - I should have checked first whether gst_bin_new returns a floating reference.

Regarding the ASSERT, I'm working with a release build so it's ifdef'ed out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.