[Webkit-unassigned] [Bug 93809] [CSS Regions] Setting region-break-after: always on a <br> element does not cause a region break

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93809





--- Comment #9 from Mihnea Ovidenie <mihnea at adobe.com>  2013-07-08 02:42:50 PST ---
(In reply to comment #8)
> Created an attachment (id=205530)
 --> (https://bugs.webkit.org/attachment.cgi?id=205530&action=review) [details]
> Example test fixing the issue adding an empty content
> 
> (In reply to comment #7)
> > childrenInline() is TRUE for <br> and FALSE for <span> because in the case of <span> RenderObject::isInline() returns FALSE, which causes that RenderBlock::makeChildrenNonInline() is called inside RenderBlock::addChildIgnoringAnonymousColumnBlocks(). However, <br> RenderObject::isInline() returns TRUE.
> 
> Actually the reason why isInline() returns FALSE for <span> elements is because of they have "display:block", if you remove that line then the breaks don't work either with <span> tags.
> 
> It seems that the breaks only work for blocks and not for inline elements.
> 

Yes, this is the definition of forced breaks: http://www.w3.org/TR/2012/WD-css3-break-20120823/#break-properties

> > Maybe in this case <br> elements with a region break should be marked as non-inline or something like that.
> 
> On the other hand in order to fix the issue with <br> elements is enough with adding "content: "";" in the CSS (as in the attached example). Because of before/after pseudo-elements are not applied if they don't have content. This is not needed for <span> elements because of they always have a content (at least an empty string).

I am confused about your mention of pseudo-elements. I see the fix with the content but i would rather see what it takes to fix it in the code. Probably such a fix would also fix for multicolumn element in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.