[Webkit-unassigned] [Bug 118417] [GTK] FrameLoaderClient: Refactor naked pointers to use smart pointers
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 5 08:47:02 PDT 2013
https://bugs.webkit.org/show_bug.cgi?id=118417
--- Comment #3 from Mario Sanchez Prada <mario at webkit.org> 2013-07-05 08:49:01 PST ---
(From update of attachment 206155)
View in context: https://bugs.webkit.org/attachment.cgi?id=206155&action=review
Good patch. I've just added a couple of minor comments as an informal review.
> Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1075
> + if (isHandled || !shouldFallBack(error)) {
You don't need that extra { now you got a single line if
> Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:1084
> + GRefPtr<GFile> errorFile(adoptGRef(g_file_new_for_uri(errorURI.get())));
We normally use the = assignment for this kind of statments:
GRefPtr<GFile> errorFile = adoptGRef(g_file_new_for_uri(errorURI.get()));
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list