[Webkit-unassigned] [Bug 117733] [WK2][GTK] ASSERTION in WebKit::LayerTreeHostGtk::invalidate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 4 12:49:51 PDT 2013


--- Comment #12 from Martin Robinson <mrobinson at webkit.org>  2013-07-04 12:51:50 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > > But we still need to invalidate and destroy the object, so we
> > > should probably attempt to create the glContext() at the beginning
> > > of the initialize method then.
> > I don't think we need to explicitly invalidate the object because
> > when the RefPtr goes out of scope in LayerTreeHostGtk::create, the
> > destructor will clean up its members. The only reason this doesn't
> > happen now is because we call host.release().
> We do because of the ASSERT(!m_rootLayer) in the destructor.

There's no reason the assertion has to remain, if the situation is no longer unexpected. :)

> DrawingAreaImpl::enterAcceleratedCompositingMode() is also not
> considering the possibility that LayerTreeHost::create() returns 0.

This seems to be a bigger issue. It seems the code has changed a bit since I originally wrote it, as returning null would disable AC implicitly. It's probably safer to check during initialization if the system supports XComposite and XDamage and force the page settings to disable AC if not.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list