[Webkit-unassigned] [Bug 118359] [ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118359





--- Comment #7 from Mario Sanchez Prada <mario at webkit.org>  2013-07-04 02:54:11 PST ---
Thanks for the review Carlos. I'm submitting this patch soon with your points addressed.

(In reply to comment #6)
> (From update of attachment 206007 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206007&action=review
> 
> > Source/WebKit/gtk/tests/testatk.c:952
> > +    webkit_web_view_load_string(webView, contentsWithWrappedLines, 0, 0, 0);
> 
> Don't you need to run a main loop and wait until the page is loaded to continue with the test?

Not anymore. It's enough with spinning manually the current loop to ensure the web is loaded when getting the root element, which is performed internally in getWebAreaObject().

> > Source/WebKit/gtk/tests/testatk.c:956
> > +    g_object_set(G_OBJECT(settings), "enable-caret-browsing", TRUE, NULL);
> 
> g_object_set receives a gpointer, not a GObject, so you don't need the cast.

Will fix.

> > Source/WebKit/gtk/tests/testatk.c:995
> > +    /* Check the paragraph with the text wrapped because of <br> elements. */
> 
> You are mixing C and C++ comments in this test, please fix it before landing.

Will fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.