[Webkit-unassigned] [Bug 118326] Preparing WebCore to receive Nix Port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118326





--- Comment #6 from Hugo Parente Lima <hugo.lima at openbossa.org>  2013-07-03 14:26:57 PST ---
Hi, thanks for spend time reviewing the code.

(In reply to comment #5)
> (From update of attachment 205945 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=205945&action=review
> 
> > Source/WebCore/platform/DragImage.h:64
> > -#elif PLATFORM(GTK)
> > +#elif PLATFORM(GTK) || PLATFORM(NIX)
> >      typedef cairo_surface_t* DragImageRef;
> 
> I wonder why this isn't under USE(CAIRO).

Efl port also use Cairo and it's not included in this #if.

> > Source/WebCore/platform/FileSystem.h:124
> > -#elif PLATFORM(GTK)
> > +#elif PLATFORM(GTK) || PLATFORM(NIX)
> >  typedef GFileIOStream* PlatformFileHandle;
> 
> I wonder if we should add USE(GLIB). It's quite confusing that "G" types are used by two platforms, one of which doesn't have a "G" in its name.

Efl port also uses Glib in some places and it's not named GEfl, so Nix doesn't need to be named GNix ;-).

For sure some Efl/Gtk/Nix code can be unified under a common glib directory/prefix, this is planned by us but we need to go one step at time.

> > Source/WebCore/platform/PlatformMenuDescription.h:38
> > +#elif PLATFORM(NIX)
> > +#include <wtf/Vector.h>
> 
> Why is this needed?  You are not changing this file in any other way, and this file is not using Vector.

True, this change must go on the cpp file using it.

> > Source/WebCore/platform/audio/FFTFrame.h:189
> > +#if PLATFORM(NIX)
> > +    void scalePlanarData(float scale);
> > +    OwnPtr<WebKit::WebFFTFrame> m_fftFrame;
> > +#endif // PLATFORM(NIX)
> 
> Ugh, WebCore is not supposed to know anything about WebKit. This is a terrible layering violation.

The name may be confused you, this WebKit namespace isn't WebKit, it's the code located on our Platform library, similar to what Chromium had, the idea is to delegate the backend logic out of WebCore to an external library, and the external library knows nothing about WebCore, WebKit, etc.. the namespace name was indeed inherited from the name Chromium used in their API's.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.