[Webkit-unassigned] [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 10:50:24 PDT 2013


--- Comment #21 from Christophe Dumez <dchris at gmail.com>  2013-07-03 10:52:22 PST ---
(From update of attachment 206009)
View in context: https://bugs.webkit.org/attachment.cgi?id=206009&action=review

>>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:56
>>> +static char* getAtkAttributeSetAsString(AtkObject* accessible)
>> gchar
> Regarding the gchars, I was under the impression that for new code that is not exposed to the outside world we should be using the non-g-versions.  If that's not correct then I will happily change to gchars throughout.

Hmm, I'm not aware of that. Last I heard, gchar was preferred but the situation might have changed since then. Do you have a link to a review / comment supporting what you're saying?

>>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:474
>>>          return JSStringCreateWithCharacters(0, 0);
>> It looks a bit weird that we return 0 below but not here.
> That's a good point.  Shall I do
> JSStringRef jsString = attributeValue ? JSStringCreateWithUTF8CString(attributeValue)
>                                       : JSStringCreateWithCharacters(0, 0);

Just "return 0;" here for consistency.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list