[Webkit-unassigned] [Bug 118359] [ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 3 10:30:39 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #206007|review?                     |review+
               Flag|                            |

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2013-07-03 10:32:37 PST ---
(From update of attachment 206007)
View in context: https://bugs.webkit.org/attachment.cgi?id=206007&action=review

> Source/WebKit/gtk/tests/testatk.c:952
> +    webkit_web_view_load_string(webView, contentsWithWrappedLines, 0, 0, 0);

Don't you need to run a main loop and wait until the page is loaded to continue with the test?

> Source/WebKit/gtk/tests/testatk.c:956
> +    g_object_set(G_OBJECT(settings), "enable-caret-browsing", TRUE, NULL);

g_object_set receives a gpointer, not a GObject, so you don't need the cast.

> Source/WebKit/gtk/tests/testatk.c:995
> +    /* Check the paragraph with the text wrapped because of <br> elements. */

You are mixing C and C++ comments in this test, please fix it before landing.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list